Skip to content

Conversation

@Vilin97
Copy link
Contributor

@Vilin97 Vilin97 commented Jan 7, 2024

To be reviewed after #389 is merged.

@Vilin97 Vilin97 mentioned this pull request Jan 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7436985309

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 88.792%

Totals Coverage Status
Change from base Build 7364429899: 0.1%
Covered Lines: 2044
Relevant Lines: 2302

💛 - Coveralls

@Vilin97 Vilin97 marked this pull request as ready for review January 25, 2024 22:02
@isaacsas
Copy link
Member

isaacsas commented Aug 6, 2024

This looks like it simplifies the code too, so if you feel it is worth keeping and merging let me know. (I'll leave it open for now and happy to review and merge if you rebase it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants